feat: metric for counting rejected transactions (port #1415) #1445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add counter to the block executor metrics : - RejectedTransactions Resolves #1241 Unblocks #1007 - [ ] Tests written/updated - [ ] Changelog entry added in `.changelog` (we use [unclog](https://github.com/informalsystems/unclog) to manage our changelog) - [ ] Updated relevant documentation (`docs/` or `spec/`) and code comments --------- Co-authored-by: 0xEclair <[email protected]> Co-authored-by: Callum Waters <[email protected]>
cmwaters
requested review from
rootulp and
evan-forbes
and removed request for
a team
evan-forbes
previously approved these changes
Jul 31, 2024
rootulp
previously approved these changes
Jul 31, 2024
Co-authored-by: Rootul P <[email protected]>
rootulp
approved these changes
Jul 31, 2024
ninabarbakadze
approved these changes
Jul 31, 2024
evan-forbes
approved these changes
Jul 31, 2024
staheri14
approved these changes
Jul 31, 2024
rach-id
pushed a commit
that referenced
this pull request
Nov 18, 2024
Add counter to the block executor metrics : - RejectedTransactions Port of #1415 --------- Co-authored-by: Eoous <[email protected]> Co-authored-by: 0xEclair <[email protected]> Co-authored-by: Rootul P <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add counter to the block executor metrics :
Port of #1415