Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore!: replace NMTProof with Proof in nmt #1432

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

Eoous
Copy link
Contributor

@Eoous Eoous commented Jul 26, 2024

Description

Use Proof in nmt instead of NMTProof.

Changed Makefile for removing protobuf file generated by buf.

Resolves #1429


PR checklist

  • Tests written/updated
  • Changelog entry added in .changelog (we use
    unclog to manage our changelog)
  • Updated relevant documentation (docs/ or spec/) and code comments

@Eoous Eoous requested a review from a team as a code owner July 26, 2024 15:54
@Eoous Eoous requested review from cmwaters and ninabarbakadze and removed request for a team July 26, 2024 15:54
@Eoous
Copy link
Contributor Author

Eoous commented Jul 26, 2024

Currently it's not possible to exclude files via buf.yaml or other config files

Copy link
Member

@ninabarbakadze ninabarbakadze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what's the status here? @Eoous

@Eoous
Copy link
Contributor Author

Eoous commented Sep 10, 2024

what's the status here? @Eoous

I have replaced it and need to review

proto/nmt/proof.proto Outdated Show resolved Hide resolved
@rach-id rach-id changed the title chore: replace NMTProof with Proof in nmt chore!: replace NMTProof with Proof in nmt Oct 7, 2024
@Eoous Eoous requested a review from rach-id October 8, 2024 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Duplicate definition of nmt proof
3 participants