Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: adds logs for the state of the trace pull server #1401

Merged
merged 3 commits into from
Jun 21, 2024

Conversation

staheri14
Copy link
Contributor

@staheri14 staheri14 commented Jun 21, 2024

As part of migrating to Knuu for the celestia-app e2e tests, I debugged the tracing feature which required adding log messages to verify that the tracer pull server is up and running. This PR includes those log messages, which previously lived in a custom branch and were not available to everyone.
Part of celestiaorg/celestia-app#3557

@staheri14 staheri14 requested a review from a team as a code owner June 21, 2024 14:44
@staheri14 staheri14 requested review from cmwaters and rach-id and removed request for a team June 21, 2024 14:44
@staheri14 staheri14 changed the base branch from main to v0.34.x-celestia June 21, 2024 14:44
@staheri14 staheri14 marked this pull request as draft June 21, 2024 14:45
@staheri14 staheri14 self-assigned this Jun 21, 2024
@staheri14 staheri14 added the WS: Big Blonks 🔭 Improving consensus critical gossiping protocols label Jun 21, 2024
@staheri14 staheri14 marked this pull request as ready for review June 21, 2024 16:21
@staheri14 staheri14 enabled auto-merge (squash) June 21, 2024 16:22
Copy link
Collaborator

@rootulp rootulp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: PR title could use conventional commit prefix

@staheri14 staheri14 changed the title Adds logs for the state of the trace pull server chore: adds logs for the state of the trace pull server Jun 21, 2024
@staheri14 staheri14 merged commit 2e81d61 into v0.34.x-celestia Jun 21, 2024
21 checks passed
@staheri14 staheri14 deleted the sanaz/tracer-logs branch June 21, 2024 20:56
rach-id pushed a commit that referenced this pull request Nov 18, 2024
As part of migrating to Knuu for the celestia-app e2e tests, I debugged
the tracing feature which required adding log messages to verify that
the tracer pull server is up and running. This PR includes those log
messages, which previously lived in a custom branch and were not
available to everyone.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
WS: Big Blonks 🔭 Improving consensus critical gossiping protocols
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants