Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: increase the data commitment blocks limit in the API (Backport #1268) #1353

Merged
merged 2 commits into from
May 9, 2024
Merged

chore: increase the data commitment blocks limit in the API (Backport #1268) #1353

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7837161
chore: increase the data commitment blocks limit in the API (#1268)
rach-id Mar 27, 2024
f42bc57
Merge branch 'v0.34.x-celestia' into backport-data-commitment-window
rach-id May 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions pkg/consts/consts.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,5 +41,7 @@ var (
NewBaseHashFunc = sha256.New

// DataCommitmentBlocksLimit is the limit to the number of blocks we can generate a data commitment for.
// Deprecated: this is no longer used as we're moving towards Blobstream X. However, we're leaving it
// here for backwards compatibility purpose until it's removed in the next breaking release.
DataCommitmentBlocksLimit = 1000
)
9 changes: 6 additions & 3 deletions rpc/core/blocks.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@ import (
"github.com/tendermint/tendermint/libs/bytes"
cmtmath "github.com/tendermint/tendermint/libs/math"
cmtquery "github.com/tendermint/tendermint/libs/pubsub/query"
"github.com/tendermint/tendermint/pkg/consts"
ctypes "github.com/tendermint/tendermint/rpc/core/types"
rpctypes "github.com/tendermint/tendermint/rpc/jsonrpc/types"
blockidxnull "github.com/tendermint/tendermint/state/indexer/block/null"
Expand Down Expand Up @@ -333,6 +332,10 @@ func EncodeDataRootTuple(height uint64, dataRoot [32]byte) ([]byte, error) {
return append(paddedHeight, dataRoot[:]...), nil
}

// dataCommitmentBlocksLimit The maximum number of blocks to be used to create a data commitment.
// It's a local parameter to protect the API from creating unnecessarily large commitments.
const dataCommitmentBlocksLimit = 10_000 // ~33 hours of blocks assuming 12-second blocks.
rach-id marked this conversation as resolved.
Show resolved Hide resolved

// validateDataCommitmentRange runs basic checks on the asc sorted list of
// heights that will be used subsequently in generating data commitments over
// the defined set of heights.
Expand All @@ -342,8 +345,8 @@ func validateDataCommitmentRange(start uint64, end uint64) error {
}
env := GetEnvironment()
heightsRange := end - start
if heightsRange > uint64(consts.DataCommitmentBlocksLimit) {
return fmt.Errorf("the query exceeds the limit of allowed blocks %d", consts.DataCommitmentBlocksLimit)
if heightsRange > uint64(dataCommitmentBlocksLimit) {
return fmt.Errorf("the query exceeds the limit of allowed blocks %d", dataCommitmentBlocksLimit)
}
if heightsRange == 0 {
return fmt.Errorf("cannot create the data commitments for an empty set of blocks")
Expand Down
Loading