chore!: remove BlobsByNamespace #1025
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evan-forbes
changed the title
cmwaters
previously approved these changes
Jun 19, 2023
rootulp
previously approved these changes
Jun 19, 2023
|
Yeah I dug into it last week and have the fix in the Sync ABCI PR I have. It's basically caused because of the e2e docker file which upgraded to using a more recent version of rocksdb than the one that CometBFT supports. To fix this you need to replace: with in |
|
In the long term CometBFT will need to upgrade their rocksdb version then we can go back to using the |
cmwaters
approved these changes
Jun 20, 2023
rootulp
approved these changes
Jun 20, 2023
cmwaters
pushed a commit
that referenced
this pull request
Sep 20, 2023
) Bumps [bufbuild/buf-setup-action](https://github.com/bufbuild/buf-setup-action) from 1.21.0 to 1.22.0. - [Release notes](https://github.com/bufbuild/buf-setup-action/releases) - [Commits](bufbuild/buf-setup-action@v1.21.0...v1.22.0) --- updated-dependencies: - dependency-name: bufbuild/buf-setup-action dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
we are only using this in two tests in the app, and it could end up being incorrect in the future since it doesn't account for the version in the namespace in the
lessmethodif we still want this, then I think it'd be easier to maintain in the app