Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

e2e: cherry-pick latest changes from tendermint master #292

Closed
liamsi opened this issue Apr 20, 2021 · 0 comments · Fixed by #295
Closed

e2e: cherry-pick latest changes from tendermint master #292

liamsi opened this issue Apr 20, 2021 · 0 comments · Fixed by #295
Labels
C:CI Continuous integration and automation related issues C:e2e T:tendermint Type: upstream tendermint changes we want

Comments

@liamsi
Copy link
Member

liamsi commented Apr 20, 2021

We were planning to hold off merging in changes from tendermint master until 0.35 lands but @Wondertan brought up a good point: we are currently doing changes in the Consensus package and we would have repeat thos in maverick whose binary in the p2p package was recently removed in tendermint: tendermint/tendermint#6099. See also this issue: tendermint/tendermint#5575.

I think it would make sense to look into cherry-picking the corresponding changes:

That sounds easier as it is (or might be) because there might be more changes that will cause merge conficts (both from the LazyLedger as well as the tendermint side).
@liamsi liamsi added C:CI Continuous integration and automation related issues C:e2e T:tendermint Type: upstream tendermint changes we want labels Apr 20, 2021
This was referenced Apr 20, 2021
Merged
Closed
cmwaters pushed a commit that referenced this issue Mar 13, 2023
@mergify @jmalicevic
QA: v0.34 - 2/3 TM 1/3 CM (#292) (#308)
fd15b98 
* Report Skeleton

* Added results on 2/3TM and 1/3CMT

* Added img files

* Cropped pics

* First batch of results

* Fixed image offsets

* All metrics in

* Added average plots, merged with Sergios branch

* Added todo

* Updated graphs

* scaling img

* scaling img

* Added versions

---------

Co-authored-by: Sergio Mena <[email protected]>
(cherry picked from commit f6e70af)

Co-authored-by: Jasmina Malicevic <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C:CI Continuous integration and automation related issues C:e2e T:tendermint Type: upstream tendermint changes we want
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

cherrypick e2e changes regarding maverick from tm master celestiaorg/celestia-core
1 participant
@liamsi