Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

State syncing validator from malicious node may lead to a chain split #1468

Closed
rootulp opened this issue Sep 4, 2024 · 1 comment · Fixed by #1495
Closed

State syncing validator from malicious node may lead to a chain split #1468

rootulp opened this issue Sep 4, 2024 · 1 comment · Fixed by #1495
Assignees
@rootulp
Labels
T:dependencies Type: Pull requests that update a dependency file WS: Maintenance 🔧

Comments

@rootulp
Copy link
Collaborator

rootulp commented Sep 4, 2024

Context

GHSA-g5xx-c4hv-9ccc

Problem

There is a security vulnerability with state sync

Proposal

Pull upstream changes from https://github.com/cometbft/cometbft/releases/tag/v0.34.34
@rootulp rootulp added the T:dependencies Type: Pull requests that update a dependency file label Sep 4, 2024
@ninabarbakadze ninabarbakadze self-assigned this Sep 9, 2024
@rootulp rootulp assigned rootulp and unassigned ninabarbakadze Sep 17, 2024
@rootulp
Copy link
Collaborator Author

rootulp commented Sep 20, 2024 •
edited
Loading

  • This repo is currently based on CometBFT v0.34.29.
  • The security advisory was fixed in CometBFT v0.34.34.
  • The latest release in this release line is CometBFT v0.34.35.
  • The diff from v0.34.29 to v0.34.35 is 150 commits.

I'm going to try and merge v0.34.35 into v0.34.x-celestia. If that proves difficult, I'll cherry-pick the commits that resolve the security advisory.

rootulp pushed a commit to rootulp/celestia-core that referenced this issue Sep 20, 2024
@melekes @forcodedancing @andynog
consensus: return last saved BeginBlock, not a empty one (#1783)
578702c 
Otherwise, the events from app's BeginBlock won't be fired.

Closes celestiaorg#1468

Co-authored-by: forcodedancing <[email protected]>
Co-authored-by: Andy Nogueira <[email protected]>
@rootulp rootulp mentioned this issue Sep 20, 2024
Merged
2 tasks
rootulp added a commit that referenced this issue Sep 30, 2024
@rootulp @mergify
@sergio-mena @dependabot @jmalicevic @lasarojc @thanethomson @mmsqe @yihuang @stevenferrer @chillyvee @alijnmerchant21 @p-offtermatt @cason @hvanz @adizere @ebuchman @andynog @melekes @troykessler @forcodedancing @mzabaluev @AlexsandroRyan @alesforz @faddat
chore: pull cometbft v0.34.35 (#1495)
65c778d 
Closes #1468 by
pulling upstream
[v0.34.35](https://github.com/cometbft/cometbft/releases/tag/v0.34.35)
with these notable merge conflicts:
- Our repo upgraded Go past what upstream has so I choose to retain the
more recent Go version

And these changes to make unit tests pass:
1. Refactor CI to run all tests in one execution. It takes the same time
([4
mins](https://github.com/celestiaorg/celestia-core/actions/runs/11038290102/job/30661243408?pr=1495))
as it [previously
did](https://github.com/celestiaorg/celestia-core/actions/runs/10956425121).
But now it's easier to reason about the flakes.
2. Included #1503
3. Included #1501

## FLUPs
1. #1504
2. Opens #1502 and
skips that test

## Testing

I used go mod replace and verified that celestia-app can use this
version of celestia-core.
- [x] `single-node.sh`
- [x] `mocha.sh`

---------

Signed-off-by: dependabot[bot] <[email protected]>
Signed-off-by: Thane Thomson <[email protected]>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Co-authored-by: Sergio Mena <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Jasmina Malicevic <[email protected]>
Co-authored-by: Lasaro <[email protected]>
Co-authored-by: Thane Thomson <[email protected]>
Co-authored-by: mmsqe <[email protected]>
Co-authored-by: yihuang <[email protected]>
Co-authored-by: Steven Ferrer <[email protected]>
Co-authored-by: Chill Validation <[email protected]>
Co-authored-by: Aliasgar Merchant <[email protected]>
Co-authored-by: Philip Offtermatt <[email protected]>
Co-authored-by: Daniel <[email protected]>
Co-authored-by: Hernán Vanzetto <[email protected]>
Co-authored-by: Adi Seredinschi <[email protected]>
Co-authored-by: Ethan Buchman <[email protected]>
Co-authored-by: Andy Nogueira <[email protected]>
Co-authored-by: Anton Kaliaev <[email protected]>
Co-authored-by: Troy Kessler <[email protected]>
Co-authored-by: forcodedancing <[email protected]>
Co-authored-by: Mikhail Zabaluev <[email protected]>
Co-authored-by: Alexsandro <[email protected]>
Co-authored-by: Alessandro <[email protected]>
Co-authored-by: Jacob Gadikian <[email protected]>
rach-id pushed a commit that referenced this issue Nov 18, 2024
@rootulp @mergify
@sergio-mena @dependabot @jmalicevic @lasarojc @thanethomson @mmsqe @yihuang @stevenferrer @chillyvee @alijnmerchant21 @p-offtermatt @cason @hvanz @adizere @ebuchman @andynog @melekes @troykessler @forcodedancing @mzabaluev @AlexsandroRyan @alesforz @faddat @rach-id
chore: pull cometbft v0.34.35 (#1495)
e341292 
Closes #1468 by
pulling upstream
[v0.34.35](https://github.com/cometbft/cometbft/releases/tag/v0.34.35)
with these notable merge conflicts:
- Our repo upgraded Go past what upstream has so I choose to retain the
more recent Go version

And these changes to make unit tests pass:
1. Refactor CI to run all tests in one execution. It takes the same time
([4
mins](https://github.com/celestiaorg/celestia-core/actions/runs/11038290102/job/30661243408?pr=1495))
as it [previously
did](https://github.com/celestiaorg/celestia-core/actions/runs/10956425121).
But now it's easier to reason about the flakes.
2. Included #1503
3. Included #1501

## FLUPs
1. #1504
2. Opens #1502 and
skips that test

## Testing

I used go mod replace and verified that celestia-app can use this
version of celestia-core.
- [x] `single-node.sh`
- [x] `mocha.sh`

---------

Signed-off-by: dependabot[bot] <[email protected]>
Signed-off-by: Thane Thomson <[email protected]>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Co-authored-by: Sergio Mena <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Jasmina Malicevic <[email protected]>
Co-authored-by: Lasaro <[email protected]>
Co-authored-by: Thane Thomson <[email protected]>
Co-authored-by: mmsqe <[email protected]>
Co-authored-by: yihuang <[email protected]>
Co-authored-by: Steven Ferrer <[email protected]>
Co-authored-by: Chill Validation <[email protected]>
Co-authored-by: Aliasgar Merchant <[email protected]>
Co-authored-by: Philip Offtermatt <[email protected]>
Co-authored-by: Daniel <[email protected]>
Co-authored-by: Hernán Vanzetto <[email protected]>
Co-authored-by: Adi Seredinschi <[email protected]>
Co-authored-by: Ethan Buchman <[email protected]>
Co-authored-by: Andy Nogueira <[email protected]>
Co-authored-by: Anton Kaliaev <[email protected]>
Co-authored-by: Troy Kessler <[email protected]>
Co-authored-by: forcodedancing <[email protected]>
Co-authored-by: Mikhail Zabaluev <[email protected]>
Co-authored-by: Alexsandro <[email protected]>
Co-authored-by: Alessandro <[email protected]>
Co-authored-by: Jacob Gadikian <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rootulp rootulp

Labels
T:dependencies Type: Pull requests that update a dependency file WS: Maintenance 🔧
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: pull cometbft v0.34.35 rootulp/celestia-core
3 participants
@rootulp @evan-forbes @ninabarbakadze