Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TestTxPool_ConcurrentlyAddingTx is flaky #1383

Closed
staheri14 opened this issue Jun 7, 2024 · 0 comments · Fixed by #1501
Closed

TestTxPool_ConcurrentlyAddingTx is flaky #1383

staheri14 opened this issue Jun 7, 2024 · 0 comments · Fixed by #1501
Assignees
@rootulp
Labels
flake A test flake that occurred on Github CI WS: Maintenance 🔧

Comments

@staheri14
Copy link
Contributor

Problem

The TestTxPool_ConcurrentlyAddingTx appears to be flaky.
Please see https://github.com/celestiaorg/celestia-core/actions/runs/9419666295/job/25949967898?pr=1379

--- FAIL: TestTxPool_ConcurrentlyAddingTx (0.00s)
    pool_test.go:737: 
        	Error Trace:	/home/runner/work/celestia-core/celestia-core/mempool/cat/pool_test.go:737
        	Error:      	Not equal: 
        	            	expected: 9
        	            	actual  : 6
        	Test:       	TestTxPool_ConcurrentlyAddingTx

Re-running the jobs make it pass, so confirming the flakiness.

Acceptance Criteria

Investigating the root cause of flakiness and making necessary modifications to resolve it.
@staheri14 staheri14 added the flake A test flake that occurred on Github CI label Jun 7, 2024
@rootulp rootulp mentioned this issue Sep 25, 2024
Merged
2 tasks
@rootulp rootulp self-assigned this Sep 25, 2024
@rootulp rootulp mentioned this issue Sep 25, 2024
Merged
rootulp added a commit that referenced this issue Sep 25, 2024
@rootulp
fix: TestTxPool_ConcurrentlyAddingTx (#1501)
9327f2b 
Closes #1383

## Testing

```
$ go test ./... -run "TestTxPool_ConcurrentlyAddingTx" -count=1000
ok  	github.com/tendermint/tendermint/mempool/cat	0.402s
```
rach-id pushed a commit that referenced this issue Nov 18, 2024
@rootulp @rach-id
fix: TestTxPool_ConcurrentlyAddingTx (#1501)
f04bc28 
Closes #1383

## Testing

```
$ go test ./... -run "TestTxPool_ConcurrentlyAddingTx" -count=1000
ok  	github.com/tendermint/tendermint/mempool/cat	0.402s
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rootulp rootulp

Labels
flake A test flake that occurred on Github CI WS: Maintenance 🔧
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: TestTxPool_ConcurrentlyAddingTx rootulp/celestia-core
2 participants
@rootulp @staheri14