-
Notifications
You must be signed in to change notification settings - Fork 269
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove square size from data root tuple root generation #1040
Comments
@cmwaters @evan-forbes I believe this is where we should remove the square size from: celestia-core/proto/tendermint/types/types.proto Lines 84 to 104 in c3ab251
However, we still need the data root for the QGB. Is there a different way to get it so that we also remove it from here and only leave txs? |
The data root is actually also part of the header so we can retrieve it from that |
## Description Closes #1040 After merging this one, I will cherry-pick this change for main. Then, I will open a separate PR for main to remove the square size and the data hash from the `Data` struct. --- #### PR checklist - [ ] Tests written/updated - [ ] Changelog entry added in `.changelog` (we use [unclog](https://github.com/informalsystems/unclog) to manage our changelog) - [ ] Updated relevant documentation (`docs/` or `spec/`) and code comments
## Description Closes celestiaorg#1040 After merging this one, I will cherry-pick this change for main. Then, I will open a separate PR for main to remove the square size and the data hash from the `Data` struct. --- #### PR checklist - [ ] Tests written/updated - [ ] Changelog entry added in `.changelog` (we use [unclog](https://github.com/informalsystems/unclog) to manage our changelog) - [ ] Updated relevant documentation (`docs/` or `spec/`) and code comments
Originally posted by @cmwaters in #1003 (comment)
The text was updated successfully, but these errors were encountered: