chore: rename megabyte to mebibyte

[rach-id]

Handles the renaming feedback in #3904 (comment)

[coderabbitai]

📝 Walkthrough

Walkthrough

The changes in this pull request introduce a series of benchmarking functions for testing message sending transactions within a blockchain application. These benchmarks evaluate various aspects of transaction processing, including checking, delivering, preparing, and processing proposals, with different transaction sizes. Additionally, the terminology for byte size is updated from megabyte to mebibyte, ensuring consistency in calculations related to block size.

Changes

File Path	Change Summary
app/benchmarks/benchmark_msg_send_test.go	Added multiple benchmarking functions for message sending transactions and updated constant from megabyte to mebibyte.

Possibly related PRs

• chore: ABCI methods benchmarks #3904: This PR is directly related as it introduces benchmarks for the same MsgSend transactions, including the functions BenchmarkCheckTx_MsgSend_1, BenchmarkDeliverTx_MsgSend_1, BenchmarkPrepareProposal_MsgSend_1, and others that are also present in the main PR.

Suggested reviewers

• cmwaters
• evan-forbes

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

‼️ IMPORTANT
Auto-reply has been disabled for this repository in the CodeRabbit settings. The CodeRabbit bot will not respond to your replies unless it is explicitly tagged.

• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Outside diff range and nitpick comments (1)

app/benchmarks/benchmark_msg_send_test.go (1)

320-321: Consider further improvements for consistency

While the calculation now correctly uses mebibyte, there are a few more adjustments that could enhance consistency and clarity:

1. Update the function name from calculateBlockSizeInMb to calculateBlockSizeInMiB to use the correct abbreviation for mebibytes.
2. Modify the comment above the function to mention "mebibytes" instead of "mb".

These changes would ensure full alignment with the new terminology throughout the code.

📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between d4eb75e and bcaa56e.

📒 Files selected for processing (1)

• app/benchmarks/benchmark_msg_send_test.go (2 hunks)

🧰 Additional context used

🔇 Additional comments (1)

app/benchmarks/benchmark_msg_send_test.go (1)

310-311: Correct renaming from megabyte to mebibyte

The constant has been appropriately renamed from megabyte to mebibyte, which is more accurate for the binary measurement of 1,048,576 bytes (2^20). This change aligns with the PR objective and improves terminology precision in the codebase.