Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore!: delete testground #3666

Merged
merged 2 commits into from
Jul 8, 2024
Merged

chore!: delete testground #3666

merged 2 commits into from
Jul 8, 2024

Conversation

evan-forbes
Copy link
Member

@evan-forbes evan-forbes commented Jul 7, 2024

Overview

removes testground as its no longer useful

testground is gone

@evan-forbes evan-forbes added testground directly relevant to testground usage WS: Maintenance 🔧 includes bugs, refactors, flakes, and tech debt etc labels Jul 7, 2024
@evan-forbes evan-forbes self-assigned this Jul 7, 2024
@evan-forbes evan-forbes requested a review from a team as a code owner July 7, 2024 03:46
@evan-forbes evan-forbes requested review from rach-id and ninabarbakadze and removed request for a team July 7, 2024 03:46
Copy link
Contributor

coderabbitai bot commented Jul 7, 2024

Walkthrough

The recent changes streamline the management of dependencies in specific test modules and simplify the logic for retrieving constants in the appconsts package. Specifically, the install target in the Makefile and the go.work.example module now exclude the ./test/testground directory. Additionally, the SquareSizeUpperBound function in versioned_consts.go has been simplified by directly returning a value from the v1 package. Minor comment updates were also made for clarity.

Changes

Files / Groups Change Summary
Makefile, go.work.example Updated the install target and removed ./test/testground import statement.
pkg/appconsts/versioned_consts.go Simplified the SquareSizeUpperBound function to directly return a value from the v1 package.
pkg/appconsts/versioned_consts_test.go Removed references to testground.Version and related constants in test functions.
test/util/testnode/config.go Updated the SuppressLogs field comment from "testground tests" to "network tests."

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

‼️ IMPORTANT
Auto-reply has been disabled for this repository in the CodeRabbit settings. The CodeRabbit bot will not respond to your replies unless it is explicitly tagged.

  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@celestia-bot celestia-bot requested a review from a team July 7, 2024 03:46
@evan-forbes
Copy link
Member Author

I believe the failing markdown is from our recent rename in go-square (https://github.com/celestiaorg/go-square/tree/main/shares), so merging

@evan-forbes evan-forbes merged commit de24826 into main Jul 8, 2024
33 of 34 checks passed
@evan-forbes evan-forbes deleted the evan/delete-testground branch July 8, 2024 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
testground directly relevant to testground usage WS: Maintenance 🔧 includes bugs, refactors, flakes, and tech debt etc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants