Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: always enable API in local dev scripts #2103

Merged
merged 2 commits into from
Jul 14, 2023

Conversation

rootulp
Copy link
Collaborator

@rootulp rootulp commented Jul 13, 2023

While debugging #2098 I frequently applied this patch to previous releases. Since these scripts exist for development purposes, I think it would save devs time by always enabling the API.

@rootulp rootulp added the chore optional label for items that follow the `chore` conventional commit label Jul 13, 2023
@rootulp rootulp requested review from staheri14 and rach-id July 13, 2023 20:18
@rootulp rootulp requested a review from evan-forbes as a code owner July 13, 2023 20:18
@rootulp rootulp self-assigned this Jul 13, 2023
@rootulp rootulp requested a review from cmwaters as a code owner July 13, 2023 20:18
@rootulp rootulp enabled auto-merge (squash) July 13, 2023 20:18
@MSevey MSevey requested a review from a team July 13, 2023 20:18
@codecov-commenter
Copy link

Codecov Report

Merging #2103 (2092132) into main (16f92db) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #2103   +/-   ##
=======================================
  Coverage   25.03%   25.03%           
=======================================
  Files         121      121           
  Lines       13808    13808           
=======================================
  Hits         3457     3457           
  Misses       9995     9995           
  Partials      356      356           

Copy link
Contributor

@cmwaters cmwaters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is gRPC enabled by default? It would be good to ensure that this is also enabled when running test nodes

@MSevey MSevey requested a review from a team July 14, 2023 14:33
@rootulp rootulp mentioned this pull request Jul 14, 2023
@rootulp rootulp merged commit e06116c into celestiaorg:main Jul 14, 2023
@rootulp rootulp deleted the rp/always-enable-api branch July 14, 2023 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore optional label for items that follow the `chore` conventional commit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants