Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

celestia-appd start is broken on main #3845

Closed
rootulp opened this issue Sep 5, 2024 · 1 comment · Fixed by #3851
Closed

celestia-appd start is broken on main #3845

rootulp opened this issue Sep 5, 2024 · 1 comment · Fixed by #3851
Assignees
@rootulp
Labels
bug Something isn't working WS: Maintenance 🔧 includes bugs, refactors, flakes, and tech debt etc

Comments

@rootulp
Copy link
Collaborator

rootulp commented Sep 5, 2024

Context

I'm trying to test a different PR.

Problem

On main:

$ celestia-appd start --log_level debug
Error: exit status 1

$ ./scripts/mocha.sh
celestia-app home: /Users/rootulp/.celestia-app
celestia-app version: 1.28.0-27-g4b34f8b3

Are you sure you want to delete: /Users/rootulp/.celestia-app? [y/n] y
Deleting /Users/rootulp/.celestia-app...
Initializing config files...
Settings seeds in config.toml...
Latest height: 2640395
Block height: 2638395
Trust hash: 80CB175BA2A01C412BBA7B366333CE8E7B0965DCF099D67166294F406DB47DA2
Enabling state sync in config.toml...
Downloading genesis file...
Starting celestia-appd...
Error: exit status 1

Proposal

  1. Identify why main can't start
  2. Fix it
  3. Add a unit test so that we can't break it in the future
@rootulp rootulp added bug Something isn't working WS: Maintenance 🔧 includes bugs, refactors, flakes, and tech debt etc labels Sep 5, 2024
@rootulp rootulp mentioned this issue Sep 5, 2024
Merged
@rootulp rootulp self-assigned this Sep 9, 2024
@rootulp
Copy link
Collaborator Author

rootulp commented Sep 9, 2024

@rootulp rootulp mentioned this issue Sep 9, 2024
Merged
rootulp added a commit that referenced this issue Sep 11, 2024
@rootulp
fix: show bbr error message on celestia-appd start (#3851)
226ad61 
Closes #3845

## Before

```
$ celestia-appd start
Error: exit status 1
```
## After

```
$ celestia-appd start

The BBR (Bottleneck Bandwidth and Round-trip propagation time) congestion control algorithm is not enabled in this system's kernel.
BBR is important for the performance of the p2p stack.

To enable BBR:
sudo modprobe tcp_bbr
net.core.default_qdisc=fq
net.ipv4.tcp_congestion_control=bbr
sudo sysctl -p

Then verify BBR is enabled:
sysctl net.ipv4.tcp_congestion_control

This node will get worse p2p performance using a different congestion control algorithm.
If you need to bypass this check use the --force-no-bbr flag.
Error: failed to execute 'sysctl net.ipv4.tcp_congestion_control' exit status 1
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rootulp rootulp

Labels
bug Something isn't working WS: Maintenance 🔧 includes bugs, refactors, flakes, and tech debt etc
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: show bbr error message on celestia-appd start rootulp/celestia-app
1 participant
@rootulp