You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Why are there 3 separate code blocks that invoke rootCmd.AddCommand()? It seems like they could all be consolidated into one. It looks like the multiple invocations date back from a while ago.
Proposal
Consolidate them all into one rootCmd.AddCommand() invocation. Test it by invoking celestia-appd --help and verify that all the commands are still added.
The text was updated successfully, but these errors were encountered:
<!--
Please read and fill out this form before submitting your PR.
Please make sure you have reviewed our contributors guide before
submitting your
first PR.
-->
## Overview
Closes#3476
Consolidated all the `rootCmd.AddCommand()` from
[initRootCmd](https://github.com/celestiaorg/celestia-app/blob/ef67d05690d445758472b50ecacaf8a5d5f2b0f2/cmd/celestia-appd/cmd/root.go#L124)
function.
<!--
Please provide an explanation of the PR, including the appropriate
context,
background, goal, and rationale. If there is an issue with this
information,
please provide a tl;dr and link the issue.
-->
Context
celestia-app/cmd/celestia-appd/cmd/root.go
Lines 127 to 155 in ca40136
Problem
Why are there 3 separate code blocks that invoke
rootCmd.AddCommand()
? It seems like they could all be consolidated into one. It looks like the multiple invocations date back from a while ago.Proposal
Consolidate them all into one
rootCmd.AddCommand()
invocation. Test it by invokingcelestia-appd --help
and verify that all the commands are still added.The text was updated successfully, but these errors were encountered: