Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Signer should use TxStatus instead of Tx to confirm submission #3366

Closed
cmwaters opened this issue Apr 23, 2024 · 0 comments · Fixed by #3767
Closed

Signer should use TxStatus instead of Tx to confirm submission #3366

cmwaters opened this issue Apr 23, 2024 · 0 comments · Fixed by #3767
Assignees
@ninabarbakadze
Labels
WS: BestTxs Reliable and seamless transaction flow

Comments

@cmwaters
Copy link
Contributor

cmwaters commented Apr 23, 2024 •
edited
Loading

Summary

Following celestiaorg/celestia-core#1287, we should update the Signer to use it for polling as to whether the transaction has been completed.

This should eventually be piped to celestia-node and result in the deprecation of the BroadcastTxCommit method

FYI this shouldn't be backported to v1.x
@cmwaters cmwaters added enhancement New feature or request WS: BestTxs Reliable and seamless transaction flow and removed enhancement New feature or request labels Apr 23, 2024
@ninabarbakadze ninabarbakadze mentioned this issue Aug 13, 2024
Merged
mergify bot pushed a commit that referenced this issue Aug 19, 2024
@ninabarbakadze @mergify
refactor: signer to use txstatus (#3767)
8f2d6c4 
## Overview

Fixes #3366

Opens - celestiaorg/celestia-core#1453 and
celestiaorg/celestia-core#1454

(cherry picked from commit a28b9e7)

# Conflicts:
#	pkg/user/tx_client.go
@mergify mergify bot mentioned this issue Aug 19, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ninabarbakadze ninabarbakadze

Labels
WS: BestTxs Reliable and seamless transaction flow
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor: signer to use txstatus celestiaorg/celestia-app
2 participants
@cmwaters @ninabarbakadze