Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: ci-release workflow fails at the golangci-lint job #3195

Closed
staheri14 opened this issue Mar 20, 2024 · 0 comments · Fixed by #3197
Closed

fix: ci-release workflow fails at the golangci-lint job #3195

staheri14 opened this issue Mar 20, 2024 · 0 comments · Fixed by #3197

Comments

@staheri14
Copy link
Collaborator

staheri14 commented Mar 20, 2024 •
edited
Loading

The main branch's CI is experiencing a failure in the golangci-lint job, requiring resolution.
A minimal PR has been submitted to illustrate the failures.

From async conversations with @evan-forbes:
@rootulp rootulp mentioned this issue Mar 20, 2024
Merged
rootulp added a commit that referenced this issue Mar 20, 2024
@rootulp
chore: upgrade to golangci-lint v1.57.0 (#3197)
cee9cd4 
Closes #3195

idk which golangci-lint release fixed the issue in
#3195 but CI passes on
this PR 🤷‍♂️
ninabarbakadze pushed a commit to ninabarbakadze/celestia-app that referenced this issue Apr 2, 2024
@rootulp @ninabarbakadze
chore: upgrade to golangci-lint v1.57.0 (celestiaorg#3197)
3a5ae58 
Closes celestiaorg#3195

idk which golangci-lint release fixed the issue in
celestiaorg#3195 but CI passes on
this PR 🤷‍♂️
0xchainlover pushed a commit to celestia-org/celestia-app that referenced this issue Aug 1, 2024
@rootulp
chore: upgrade to golangci-lint v1.57.0 (#3197)
43052bf 
Closes celestiaorg/celestia-app#3195

idk which golangci-lint release fixed the issue in
celestiaorg/celestia-app#3195 but CI passes on
this PR 🤷‍♂️
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: upgrade to golangci-lint v1.57.0 rootulp/celestia-app
1 participant
@staheri14