Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert First Block Transaction Check #2271

Closed
staheri14 opened this issue Aug 14, 2023 · 1 comment · Fixed by #3225
Closed

Revert First Block Transaction Check #2271

staheri14 opened this issue Aug 14, 2023 · 1 comment · Fixed by #3225
Assignees
@rootulp
Labels
chore optional label for items that follow the `chore` conventional commit

Comments

@staheri14
Copy link
Contributor

Problem

Following issue #1899, we decided to add some checks to the prepare_proposal process to ensure that the first block does not contain any transactions (#2221).
However, the incorporation of this check is just to avoid unexpected errors, hence after mainnet this check becomes unnecessary and this issue is to remove this check (basically revert changes introduced in #2233) after mainnet.
@github-actions github-actions bot added needs:triage bot item was created by a bot labels Aug 14, 2023
@staheri14 staheri14 self-assigned this Aug 14, 2023
@staheri14 staheri14 mentioned this issue Aug 14, 2023
Merged
5 tasks
@staheri14 staheri14 added this to the Post-mainnet milestone Aug 14, 2023
@rootulp rootulp added chore optional label for items that follow the `chore` conventional commit and removed bot item was created by a bot needs:triage labels Aug 15, 2023
@evan-forbes evan-forbes removed this from the Post-mainnet milestone Nov 12, 2023
@rootulp
Copy link
Collaborator

rootulp commented Feb 22, 2024

Mainnet launched so should we revisit reverting #2233? I thought of this because #3122

cc: @cmwaters

@rootulp rootulp mentioned this issue Apr 1, 2024
Merged
@rootulp rootulp self-assigned this Apr 1, 2024
@rootulp rootulp added the revert label Apr 1, 2024
rootulp added a commit that referenced this issue Apr 2, 2024
@rootulp
revert: last block height == 0 check (#3225)
897b448 
Closes #2271
0xchainlover pushed a commit to celestia-org/celestia-app that referenced this issue Aug 1, 2024
@rootulp
revert: last block height == 0 check (#3225)
d569182 
Closes celestiaorg/celestia-app#2271
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rootulp rootulp

Labels
chore optional label for items that follow the `chore` conventional commit
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

revert: last block height == 0 check rootulp/celestia-app
3 participants
@rootulp @staheri14 @evan-forbes