Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for hardhat project #214

Merged
merged 4 commits into from
Oct 3, 2023

Conversation

rach-id
Copy link
Member

@rach-id rach-id commented Sep 30, 2023

Overview

This will lay foundations for using deployment and upgrades via the uups plugin, run static code analyzers, etc.

Let me know what you think of having 3 projects in the same repo:

  • go project
  • foundry project
  • hardhat project

Checklist

  • New and updated code has appropriate documentation
  • New and updated code has new and/or updated testing
  • Required CI checks are passing
  • Visual proof for any user facing features like CLI or documentation updates
  • Linked issues closed with keywords

@rach-id rach-id added the enhancement New feature or request label Sep 30, 2023
@rach-id rach-id self-assigned this Sep 30, 2023
package.json Outdated Show resolved Hide resolved
evan-forbes
evan-forbes previously approved these changes Oct 2, 2023
Copy link
Member

@evan-forbes evan-forbes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utack

lol @ js

Screenshot from 2023-10-02 05-59-27

should we include any instrustions on how to use the deploy script?

@rach-id
Copy link
Member Author

rach-id commented Oct 2, 2023

Yeah, we could document that, but I am still not convinced of this. So I opened this PR to get your opinion on it too. Also, for some reason, the generated code is different from the one we previously had, and this shouldn't happen because nothing changed in the contracts. So, I am still investigating and thinking about this

@rach-id
Copy link
Member Author

rach-id commented Oct 2, 2023

Now is fine, the remappings file was invalid.

@rach-id
Copy link
Member Author

rach-id commented Oct 2, 2023

For the instructions, I will try to add some after I prepare the deploy/upgrade scripts

hardhat.config.ts Show resolved Hide resolved
remappings.txt Show resolved Hide resolved
tsconfig.json Show resolved Hide resolved
@rach-id rach-id merged commit cf301ad into celestiaorg:master Oct 3, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants