Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: return error codes instead of reverting #189

Merged
merged 2 commits into from
Sep 9, 2023
Merged

refactor: return error codes instead of reverting #189

merged 2 commits into from
Sep 9, 2023

Conversation

rach-id
Copy link
Member

@rach-id rach-id commented Sep 8, 2023

Overview

Closes #166

Checklist

  • New and updated code has appropriate documentation
  • New and updated code has new and/or updated testing
  • Required CI checks are passing
  • Visual proof for any user facing features like CLI or documentation updates
  • Linked issues closed with keywords

@rach-id rach-id added enhancement New feature or request contracts labels Sep 8, 2023
@rach-id rach-id self-assigned this Sep 8, 2023
@rach-id rach-id merged commit 2073ba6 into celestiaorg:master Sep 9, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adlerjohn adlerjohn adlerjohn approved these changes

@evan-forbes evan-forbes Awaiting requested review from evan-forbes

Assignees

@rach-id rach-id

Labels
contracts enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Return false or revert in DAVerifier
2 participants
@rach-id @adlerjohn