Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Go wrapper and add CI check #149

Merged
merged 6 commits into from
Jun 14, 2023
Merged

Update Go wrapper and add CI check #149

merged 6 commits into from
Jun 14, 2023

Conversation

adlerjohn
Copy link
Member

@adlerjohn adlerjohn commented Jun 14, 2023 •
edited
Loading

  • Bump Go version to 1.19, since it's needed to compile the latest version of geth devtools.
  • Add CI job to check that the Go wrapper code matches what would be generated. Prevents drift/forgetting to update the wrapper.
  • Update the Go wrapper.

@adlerjohn adlerjohn added the github_actions Pull requests that update Github_actions code label Jun 14, 2023
@adlerjohn adlerjohn self-assigned this Jun 14, 2023
@adlerjohn adlerjohn marked this pull request as ready for review June 14, 2023 21:57
evan-forbes
evan-forbes approved these changes Jun 14, 2023
View reviewed changes
Copy link
Member

@evan-forbes evan-forbes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@adlerjohn adlerjohn merged commit 29987b1 into master Jun 14, 2023
@adlerjohn adlerjohn deleted the adlerjohn/update-go-wrapper-and-ci branch June 14, 2023 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rach-id rach-id rach-id approved these changes

@evan-forbes evan-forbes evan-forbes approved these changes

Assignees

@adlerjohn adlerjohn

Labels
github_actions Pull requests that update Github_actions code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@adlerjohn @rach-id @evan-forbes