Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: generate the wrappers from .abi and .bin #139

Merged
merged 6 commits into from
Mar 27, 2023

Conversation

rach-id
Copy link
Member

@rach-id rach-id commented Mar 24, 2023

Overview

The wrapper is different in this case because it will only contain the structs and helper methods for the QuantumGravityBridge contract. Previously, it was also including the other intermediary contracts like IDAOracle and others.

Checklist

  • New and updated code has appropriate documentation
  • New and updated code has new and/or updated testing
  • Required CI checks are passing
  • Visual proof for any user facing features like CLI or documentation updates
  • Linked issues closed with keywords

@rach-id rach-id requested a review from adlerjohn March 24, 2023 09:03
@rach-id rach-id self-assigned this Mar 24, 2023
Makefile Outdated Show resolved Hide resolved
scripts/gen.sh Show resolved Hide resolved
scripts/gen.sh Outdated Show resolved Hide resolved
scripts/gen.sh Outdated Show resolved Hide resolved
scripts/gen.sh Outdated Show resolved Hide resolved
Copy link
Member

@adlerjohn adlerjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK, will trust it's tested. The script might fail is the filename has spaces, but you can fix that in a follow-up issue.

@rach-id
Copy link
Member Author

rach-id commented Mar 27, 2023

@adlerjohn
dd73d7c I removed the --type to keep the default prefix for the structs generated for the contracts:

QgbMetaData  => WrappersMetaData

So that we don't have the redundant Qgb prefix everywhere, even for contracts that are not the QuantumGravityBridge.sol contract. What do you think?

@rach-id rach-id merged commit 5edb590 into celestiaorg:master Mar 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants