Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Redis WATCH to prefixed complex commands #1572

Merged
merged 1 commit into from
Jul 14, 2022
Merged

Add Redis WATCH to prefixed complex commands #1572

merged 1 commit into from
Jul 14, 2022

Conversation

dcecile
Copy link
Contributor

@dcecile dcecile commented Jul 11, 2022 •
edited
Loading

The Redis WATCH command accepts multiple keys as arguments -- all of those keys should be prefixed using the global_keyprefix setting.

Kombu does not execute this command directly, but the command is used when running Redis transactions (restore tag and restore message).

Fixes #1569

@dcecile dcecile changed the title Add WATCH to prefixed complex commands Add Redis WATCH to prefixed complex commands Jul 11, 2022
@dcecile dcecile mentioned this pull request Jul 11, 2022
Closed
@auvipy auvipy added this to the 5.3 milestone Jul 12, 2022
@auvipy auvipy self-requested a review July 14, 2022 04:12
auvipy
auvipy requested changes Jul 14, 2022
View reviewed changes
Copy link
Member

@auvipy auvipy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need to adjust some documentation for the added new command?

@dcecile
Copy link
Contributor Author

dcecile commented Jul 14, 2022

do we need to adjust some documentation for the added new command?

I looked into the previous global_keyprefix PRs #1349 and #1495, and it seems like they have already documented the global_keyprefix parameter itself and the prefix-aware Redis subclasses.

What kind of documentation are you thinking about?

@auvipy auvipy merged commit 4440c64 into celery:master Jul 14, 2022
@dcecile dcecile deleted the patch-1 branch July 14, 2022 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@auvipy auvipy auvipy approved these changes

Assignees
No one assigned
Labels
Component: Redis Broker
Projects
v5.3
Status: Done
Milestone
5.3
Development

Successfully merging this pull request may close these issues.

Redis CROSSSLOT error for WATCH command
2 participants
@dcecile @auvipy