chore: Refactor code quality issues #1320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request introduces 1 alert when merging 73aa78a into 4979c3a - view on LGTM.com new alerts:
|
|
unit tests are failing |
|
@auvipy I've fixed the errors. Thanks! |
auvipy
approved these changes
Mar 21, 2021
|
@thedrow I think we can add this, what do you think? |
matusvalo
requested changes
Mar 22, 2021
|
@matusvalo any updates on this? |
|
@akshgpt7 Please address the code review comments. |
|
This pull request introduces 1 alert when merging c5d285a into 7c34684 - view on LGTM.com new alerts:
|
thedrow
approved these changes
Apr 7, 2021
matusvalo
added a commit
to matusvalo/kombu
that referenced
this pull request
May 19, 2021
matusvalo
added a commit
that referenced
this pull request
May 19, 2021
This reverts commit 3b6cd13.
matusvalo
added a commit
that referenced
this pull request
May 19, 2021
auvipy
pushed a commit
that referenced
this pull request
May 25, 2021
* Fix broken nested() after #1320 * Remove backward compatible code not needed anymore
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Hey, I'm a Developer Outreach at DeepSource and ran DeepSource analysis on my fork of the repo. It found some interesting code quality and performance improvements to consider.
This PR fixes a few of the issues detected for you to assess if it is right for you.
Happy to provide the tweaks separately otherwise :)
Summary of changes
ifstatement.sys.exit()instead of bareexit()..deepsource.tomlfile for continuous analysis on bug risks/performance/code-quality issues on new changes.