Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow specifying session token #1283

Merged
merged 3 commits into from
Jan 5, 2021
Merged

Allow specifying session token #1283

merged 3 commits into from
Jan 5, 2021

Conversation

flying-sheep
Copy link
Contributor

This is useful for local testing using something like gimme-aws-creds

@auvipy
Copy link
Member

auvipy commented Dec 14, 2020

should this change also need mentions in docs?

@flying-sheep
Copy link
Contributor Author

flying-sheep commented Dec 14, 2020

Oh, probably!

We might also want to think about how to mention it, because it’s not something for production code – a session token is only valid for a while, so this is for testing your code locally, while you’d be using roles on AWS.

But it is useful. I’d have had a hard time verifying that my project works without this.

@matusvalo
Copy link
Member

@flying-sheep I think at least you can comment the method itself and also you can put a note to docstring of the module.

@flying-sheep
Copy link
Contributor Author

done!

@auvipy auvipy merged commit 43190b2 into celery:master Jan 5, 2021
@flying-sheep flying-sheep deleted the patch-1 branch January 5, 2021 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants