Switch from pkg_resources importlib-metadata #1071
Conversation
|
looks like appveyor failed to install some unrelated dependency |
See e.g. pypa/setuptools#510 (comment) On a moderatly large project (~200 packages) at $work this saves ~150 ms on `python -c 'from kombu import Exchange'`
davidszotten
force-pushed
the
importlib_metadata
branch
from
870f2c9
to
c3666a4
Compare
Codecov Report
@@ Coverage Diff @@
## master #1071 +/- ##
==========================================
- Coverage 88.62% 88.62% -0.01%
==========================================
Files 64 64
Lines 6692 6689 -3
Branches 805 805
==========================================
- Hits 5931 5928 -3
Misses 668 668
Partials 93 93
Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #1071 +/- ##
==========================================
- Coverage 88.62% 88.62% -0.01%
==========================================
Files 64 64
Lines 6692 6689 -3
Branches 805 805
==========================================
- Hits 5931 5928 -3
Misses 668 668
Partials 93 93
Continue to review full report at Codecov.
|
|
should we wait for this change into a major version like 4.7? |
|
don't feel strongly either way. what's the typical release cadence for major and minor (=patch?) versions atm? i should also note that i don't use any kombu plugins myself. i made a dummy one to check this works (since the tests mock it out) but it would be good with some more tests if you know of projects making use of plugins |
|
report about breakage of kombu with py2.7 here #1096 could you check? |
See e.g. pypa/setuptools#510 (comment)
On a moderatly large project (~200 installed packages) at $work this saves ~150 ms on
python -c 'from kombu import Exchange'