Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add kafka broker docs #8935

Merged
merged 5 commits into from
May 1, 2024
Merged

add kafka broker docs #8935

merged 5 commits into from
May 1, 2024

Conversation

thuibr
Copy link
Contributor

@thuibr thuibr commented Mar 28, 2024

Note: Before submitting this pull request, please review our contributing
guidelines
.

Description

Add documentation for setting up Kafka as a broker.

@thuibr
Copy link
Contributor Author

thuibr commented Mar 28, 2024

@Nusnus I saw you in PR #8805, so I thought I'd ask you, how do I go about requesting a review for this PR? This is my first PR. Thanks!

@Nusnus Nusnus self-requested a review March 28, 2024 15:08
@Nusnus
Copy link
Member

Nusnus commented Mar 28, 2024

@Nusnus I saw you in PR #8805, so I thought I'd ask you, how do I go about requesting a review for this PR? This is my first PR. Thanks!

GitHub has a field for reviewers on the right panel (on Desktop). I've added myself and will review it 😊

@thuibr
Copy link
Contributor Author

thuibr commented Mar 28, 2024

@Nusnus I saw you in PR #8805, so I thought I'd ask you, how do I go about requesting a review for this PR? This is my first PR. Thanks!

GitHub has a field for reviewers on the right panel (on Desktop). I've added myself and will review it 😊

Thanks! I don't seem to be able to add reviewers myself.

@thuibr thuibr marked this pull request as draft April 2, 2024 10:57
@thuibr thuibr marked this pull request as ready for review April 17, 2024 10:23
@auvipy auvipy merged commit 5386e3e into celery:main May 1, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants