Move completed-epoch handling out of task_manager #299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Check-perf-impact results: (a2d9681a083c32e2b46fe0fbb689f304) Relative execution time per category: (mean of relative medians)
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Pull Request Test Coverage Report for Build 11839608873Details
💛 - Coveralls |
PeterTh
approved these changes
Nov 11, 2024
fknorr
force-pushed
the
epoch-promise
branch
from
c7c1bd4 to
e0a6453
Compare
|
Check-perf-impact results: (a42f16ae449d806ee4af2ef57be62d77) ❓ No new benchmark data submitted. ❓ |
Replaces `epoch_monitor` with an atomic counter in `runtime` for the purpose of TDAG pruning, and re-uses the fence promise mechanism for suspending the main thread when waiting on an epoch task. This consolidates the "previous horizon is applied as an epoch" logic, which was previously duplicated, in a single location in `runtime`. Furthermore, `task_graph` ownership is moved out of `task_manager`, making it a single-threaded graph generator like the others. A rename to `task_graph_generator` should follow eventually but was omitted here to keep diff noise low.
fknorr
force-pushed
the
epoch-promise
branch
from
e0a6453 to
9b596a4
Compare
|
Check-perf-impact results: (bb30e23d8de4cfa5e0bbdb911e0279cc) Relative execution time per category: (mean of relative medians)
|
This was referenced Nov 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces
epoch_monitorwith an atomic counter inruntimefor the purpose of TDAG pruning, and re-uses the fence promise mechanism for suspending the main thread when waiting on an epoch task.This consolidates the "previous horizon is applied as an epoch" logic, which was previously duplicated, in a single location in
runtime.Furthermore,
task_graphownership is moved out oftask_manager, making it a single-threaded graph generator like the others. A rename totask_graph_generatorshould follow eventually but was omitted here to keep diff noise low.