Fix MacOS builds code signing #114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mac OS builds linked with zig are improperly output, making them impossible to sign & notarize, thus making it difficult to use in professional electron apps/games. This goes back to building MacOS builds on MacOS with XCode's linker to produce correct build outputs.
|
Note: This is intended to fix #103. |
|
This PR seems important. Can we merge it? |
|
@ceifa Just checking in on this to see if there's any concerns or issues preventing it from being merged? |
|
sorry guys, I'm very busy these days, merging it now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mac OS builds linked with zig are improperly output, making them impossible to sign & notarize, thus making it difficult to use in professional electron apps/games.
This goes back to building MacOS builds on MacOS with XCode's linker to produce correct build outputs.
Fixes #103