Skip to content
This repository has been archived by the owner on Jun 18, 2023. It is now read-only.

BUG: corner cases #88

Closed
ceholden opened this issue Apr 27, 2016 · 2 comments
Closed

BUG: corner cases #88

ceholden opened this issue Apr 27, 2016 · 2 comments
Labels
Milestone

Comments

@ceholden
Copy link
Owner

  1. In very short time series (e.g., edge of images), CCDCesque implementation can sometimes not estimate regression models for the non-test indices.
    • If we train a model but cannot monitor for even a single observation, self._update_model() will not be called because it is in the monitoring block
    • Fix: run self._update_model as soon as the training stage finishes so that all p features may be estimated
  2. Again, in very short time series when n = p, the RLM code will throw a DGELSD error
    • When n = p, the residuals are resid < epsilon (i.e., 0)
    • When all residuals are 0, the initial scale estimate is also 0
    • Fix: return when the initial scale estimate is 0
@ceholden ceholden added the bug label Apr 27, 2016
@ceholden ceholden modified the milestones: v1.0.0, v0.6.1: Bug fix release Apr 27, 2016
parevalo added a commit to parevalo/yatsm that referenced this issue Apr 28, 2016
@parevalo
Copy link
Contributor

Wondering if the fix is as simple as the changes I made, so I referenced the issue in the commit I made to my own repository. I ran the pixel with no errors, BTW.

@ceholden
Copy link
Owner Author

ceholden commented Apr 28, 2016

Awesome! I have a two nitpicks I'd like you to address and then we could merge it into the main repo. I'll comment on your commit with them.

It would also be good if you could separate the two fixes into two different commits. Again, a nitpick but it is good to isolate changes, especially when we're changing the algorithms.

Thank you!

ceholden added a commit that referenced this issue May 1, 2016
@ceholden ceholden closed this as completed May 1, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants