Unittests

[JanEggers]

i ported the unittests to use xunit

in the spirit of tdd they are red now so good luck @jornh to integrate them.

sadly cef tries to start the subprocess from vs testwindow app and not from the path i specified in the browsersettings which is quite confusing.

[JanEggers]

@perlun @jornh anyone ideas why appveyor cant download the packages i got them from the visual studio interface as usual and for me they worked

[jornh]

Nice stuff Jan! Starting with red is a start - even tough I thought it should be red due to missing features - not the test code 😛

No idea on why it can't download! I assumed it would just "automagically work" with auto-discovery of tests without any setup for me to do like it did for NUnit. So I'm surprised to see it go red because it can't fetch a package. I'll try it out locally when I get a moment.

Maybe we have to give it a nudge somehow; See if it fails on an older dependency, explicitly set up a package source etc. If it keeps failing I can try to get in touch with the AppVeyor folks - it might affect others too.

[jornh]

Moving discussion from https://github.com/JanEggers/CefSharp/issues/1 over here ...

Yes, copying the xUnit runner to the relevant CefSharp.Test/bin/ dir seems to be it. Now it gets past the file io expection and to this, which sounds like #351 could now be blocking #366 progress:

System.ArgumentException: Cannot pass a GCHandle across AppDomains.
Parameter name: handle
   at System.Runtime.InteropServices.GCHandle.InternalCheckDomain(IntPtr handle)

   at System.Runtime.InteropServices.GCHandle.FromIntPtr(IntPtr value)
   at gcroot<CefSharp::ManagedCefBrowserAdapter ^>.->(gcroot<CefSharp::ManagedCe
fBrowserAdapter ^>* )
   at CefSharp.Internals.ClientAdapter.OnAfterCreated(ClientAdapter* , CefRefPtr
<CefBrowser>* browser)
System.InvalidOperationException: The calling thread cannot access this object b
ecause a different thread owns it.
   at System.Windows.Threading.Dispatcher.VerifyAccess()
   at System.Windows.DependencyObject.SetValue(DependencyProperty dp, Object val
ue)
   at CefSharp.Wpf.WebView.Dispose(Boolean isdisposing)
   at CefSharp.Wpf.WebView.Dispose()
   at CefSharp.Cef.Shutdown()
   at CefSharp.Cef.ParentProcessExitHandler(Object sender, EventArgs e)

[amaitland]

System.InvalidOperationException: The calling thread cannot access this object because a different thread owns it.

@jornh Need to call WebBrowser = null on the UI thread to resolve that problem.

Change required is in the WIP branch I've been working on which can be found here amaitland@298b570
Feel free to cheery pick if you need to merge it sooner rather than later.

[jornh]

Cool @amaitland! Thanks a bunch for the 🍒 ... Jan actually mentioned something - but I forgot again. Guess, I'm running low on energy. Better go compile some food ... 😄

[amaitland]

@jornh No probs! I'll catch you on the flip side, it's sleep time for me 😄

[jornh]

Sleep well! Right past midnight if you are on Sidney time? http://everytimezone.com/

[amaitland]

@jornh Pretty much spot on, I'm in Brisbane (same time zone as Sydney) 😄

[JanEggers]

@jornh @amaitland : is there a chance to merge this even if its useless atm.

i would rather start a new pr for resolving #351 as it will bring some structural changes with it as we have to rely more on delegates for callbacks as it seems.

[jornh]

Good point! No reason not to merge it now. It's still a step in the right direction. As long as auto discover of xUnit tests are disabled on appveyor it's not doing any harm. Merging it now.

[amaitland]

Nice to see the PR queue getting smaller, fantastic work guys! 😄