Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure CefSettings.CachePath and RequestContextSettings.CachePath are absolute #3102

Closed
1 task done
amaitland opened this issue Apr 16, 2020 · 4 comments
Closed
1 task done

Ensure CefSettings.CachePath and RequestContextSettings.CachePath are absolute #3102

amaitland opened this issue Apr 16, 2020 · 4 comments
Assignees
@amaitland
Labels
breaking-change
Milestone
81.3.x

Comments

@amaitland
Copy link
Member

amaitland commented Apr 16, 2020 •
edited
Loading

The cache path must be an absolute path. It was never intended to work with relative paths.

As per https://bitbucket.org/chromiumembedded/cef/issues/2916/not-persisting-in-local-stoage-when-using#comment-56993126 the CachePath must be absolute.

  • throw Exception if paths are non absolute

Related issue #3074
@amaitland amaitland added this to the 81.0.0 milestone Apr 16, 2020
@amaitland amaitland self-assigned this Apr 16, 2020
@amaitland amaitland mentioned this issue Apr 16, 2020
Closed
@amaitland amaitland changed the title Ensure [CefSettings|RequestContextSettings].CachePath is absolute Ensure CefSettings.CachePath and RequestContextSettings.CachePath are absolute Apr 16, 2020
@amaitland

This comment has been minimized.

Sign in to view
@amaitland
Copy link
Member Author

Browsersubprocess must also be absolute now

https://bitbucket.org/chromiumembedded/cef/commits/dede95c5866fee73db7fb0e5f2077fb2135db6ac

@amaitland
Copy link
Member Author

The exception in https://github.com/cefsharp/CefSharp/blob/master/CefSharp.Core/Cef.h#L204 should be updated to make it clear an absolute path is required also.

amaitland added a commit that referenced this issue Apr 28, 2020
@amaitland
Example - Make BrowserSubProcess paths absolute
4d7fa50 
Issue #3102
amaitland added a commit that referenced this issue May 3, 2020
@amaitland
Core - Add DependencyChecker.AssertPathAbsolute
46006b4 
Issue #3102
@amaitland amaitland reopened this May 3, 2020
amaitland added a commit that referenced this issue May 3, 2020
@amaitland
Core - PathCheck rewrite to match Chromium FilePath::IsAbsolute
98b7abe 
Resovles #3102
@amaitland
Copy link
Member Author

Resolved in 98b7abe

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@amaitland amaitland

Labels
breaking-change
Projects
None yet
Milestone
81.3.x
Development

No branches or pull requests
1 participant
@amaitland