-
-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unittest / CI #303
Comments
Sounds good! We actually already have a project set up a TeamCity, so we should coordinate a bit on that part. I could see if I can make you have access to that... |
Whoa! 😄 I was wondering where all the .NET people were running open source friendly CI for free - looks like CodeBetter.com is one? of the places ... Per is it http://teamcity.codebetter.com/project.html?projectId=project408&tab=projectOverview you are referring to? |
Possibly, but it just gives me a login screen 😃 |
I just logged in as Guest. Then it tells me e.g. that the CefSharp3 has VCS problems (which is understandable 😄) ... I wonder who set it up if it wasn't you? Also found this: http://codebetter.com/codebetter-ci/ we should be able to talk someone into giving us access I guess ... |
exactly |
It seems AppVeyor could be an option for the / CI part of it. I experimented a bit at jornh#1 (try clicking those little red/green things). This means we only miss the Unittest / half of it ... and then of course setting it up for the CefSharp project and not my fork if you guys think it's a fit. |
Hi, Sorry for the lack of feedback on this one from me... The CodeBetter account I've been involved with setting up, so I probably have the credentials laying around somewhere. As far as AppVeyor is concerned, it feels quite good; I looked at it previously but I didn't see that they had support for unmanaged (i.e. non-C#) stuff. @jornh, please feel free to set it up for the main repo, you have my blessing. 👍 |
No problem :) The CodeBetter site felt a bit ghost town like anyway and initial AppVeyor setup with GitHub was super easy. I'll look into a CefSharp team setup over the next few days. |
It looks like I don't have the required karma wrt. adding webhooks on the cefsharp/CefSharp repo. When trying to add it in AppVeyor I get a So a benevolent project owner needs either to up my karma for the CefSharp repo or:
That's it! When committing to any CefSharp branch it should now start a build at https://ci.appveyor.com/project/cefsharp/cefsharp - or click |
Hi, Sorry for being a bit benevolent lately. 😉 It has now been added, I also set you up as an admin there so "happy hacking" please. 😃 |
Hey, benevolence should be seen as a hallmark 😄 all fine and well Cool, thanks! I'll look into turning a few knobs to see what it can do for us ... |
@jornh i lurked around the appveyor site they can do x-unit tests should i take care of reestablish our unittest project and when im done u integrate it in appveyor ? |
Yes that be cool. Just start with what you can quickly piece together from what you have and we can go from there and toss the 5 lame passing nunit ones because they are |
Yes please, that would be great! TIA. Sent from my iPhone On 22 maj 2014, at 00:27, "JanEggers" <[email protected]mailto:[email protected]> wrote: @jornhhttps://github.com/jornh i lurked around the appveyor site they can do x-unit tests should i take care of reestablish our unittest project and when im done u integrate it in appveyor ? Reply to this email directly or view it on GitHubhttps://github.com//issues/303#issuecomment-43816477. |
Can this one be closed now? Or do you feel like the #351 issue should be fixed first? |
@jornh: can we integrate this into appveyor ? http://blog.jetbrains.com/dotnet/2013/03/26/resharper-code-analysis-goes-beyond-visual-studio/ |
Maybe - it will require download of the tool as part of every build though AFAIK Where can you find this tool ... aah it's here: http://www.jetbrains.com/resharper/features/command-line.html - free so no license key to fool around with. Feel free to try adding it - should just be a one-line addition to our I don't see any mention in their forum of support for reporting from it though. So if we want pretty reporting we might need to loop over output via http://www.appveyor.com/docs/build-agent-api#add-message or just let it fail So only thing we need to decide on is from where to get it uploaded.from (is it small enough to just add to the repo - though I'm not really a fan of that 😄) |
This has been stale for a looooong time. Do we have any unit tests running on AppVeyor now, can we close this @jornh and/or @JanEggers? |
ill close the issue i dont have any clue whats the current state of the codebase. |
I want to enable unittests again
i already migrated to xunit in a private branch as discussed with @perlun somewhere.
so one of my next tasks would be to create a cherrypick pr for that changes and then
create a Project at TeamCity.CodeBetter.com.
any thoughts on teamcity / preferences in another direction ?
The text was updated successfully, but these errors were encountered: