Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scala 2.13 cross compilation #331

Merged
merged 2 commits into from
Oct 6, 2021
Merged

Conversation

pomadchin
Copy link
Contributor

@pomadchin pomadchin commented Oct 3, 2021

This PR adds Scala 2.13 cross compilation, sets it as the default Scala version and updates all dependencies.

Closes #271, #283, #290, #315, #316, #318, #319, #320, #322, #324, #325, #328, #329, #330

@ceedubs
Copy link
Owner

ceedubs commented Oct 5, 2021

@pomadchin wow, thanks!

This is pretty much an abandoned project from me. It was probably fairly irresponsible of me to make a PR to frameless to use it in a test. Feel free to remove the dependency from frameless if this repo is ever a blocker; I won't be offended. Having said that, I appreciate your work on this and am happy to merge it if the build succeeds.

@pomadchin
Copy link
Contributor Author

:D well, we can try to make it to 2.13 at least. And indeed it is a test dependency only; we'll see what's going to happen to it 🚀

@pomadchin
Copy link
Contributor Author

🤦 don't know how it could compile locally.

@ceedubs
Copy link
Owner

ceedubs commented Oct 6, 2021

🎉 build is 🟢

Thank you, @pomadchin!

@ceedubs ceedubs merged commit 99fa3c9 into ceedubs:master Oct 6, 2021
@ceedubs
Copy link
Owner

ceedubs commented Oct 6, 2021

@pomadchin should be available now: https://oss.sonatype.org/content/repositories/snapshots/net/ceedubs/irrec-parser_2.13/0.0.0+1-99fa3c91-SNAPSHOT/

@pomadchin
Copy link
Contributor Author

Thank you! 🎉🎉🎉

@pomadchin pomadchin deleted the feature/scala-213 branch October 9, 2021 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants