Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove extra call when debounced with leading option called once #231

Merged
merged 7 commits into from
Oct 18, 2024

Conversation

102
Copy link
Collaborator

@102 102 commented Oct 18, 2024

Closes #230

@102
Copy link
Collaborator Author

102 commented Oct 18, 2024

Tests are failing both in local environment and in CI, both in the feature branch and in production with the same error message:

      } else if (result.split('\n').length !== 2) {
                        ^

TypeError: result.split is not a function
    at /Users/Roman_Gusev1/Development/youmightnotneed/node_modules/codecov/lib/codecov.js:212:25
    at /Users/Roman_Gusev1/Development/youmightnotneed/node_modules/teeny-request/build/src/index.js:217:17
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)

which seems to be unrelated to the changes from this PR

if it helps, it seems that the result value that is being returned by codecov is { message: 'Repository not found' }, which might indicate that there are some problems with the codecov setup

@cedmax
Copy link
Owner

cedmax commented Oct 18, 2024

Not sure what happened: I added the env variable and it works, but it didn't use to need it 🤷‍♀️

Copy link

codecov bot commented Oct 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (a66d611) to head (89eb71c).
Report is 4 commits behind head on production.

Additional details and impacted files
@@             Coverage Diff              @@
##           production      #231   +/-   ##
============================================
  Coverage      100.00%   100.00%           
============================================
  Files             556       556           
  Lines            2198      2200    +2     
  Branches          107       108    +1     
============================================
+ Hits             2198      2200    +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cedmax cedmax merged commit 506e96e into production Oct 18, 2024
12 checks passed
@cedmax cedmax deleted the fix/debounce-leading branch October 18, 2024 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Debounce with leading called twice on single invocation
2 participants