Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade conflicting gems #21

Merged
merged 2 commits into from
Sep 5, 2024
Merged

Upgrade conflicting gems #21

merged 2 commits into from
Sep 5, 2024

Conversation

nicolastemciuc
Copy link
Collaborator

  • Upgrade bootsnap from 1.4.6 to 1.18.4
  • Upgrade cbor from 0.5.9.6 to 0.5.9.8
  • Upgrade jaro_winkler from 1.5.4 to 1.5.6
  • Upgrade puma from 4.3.3 to 4.3.12
  • Upgrade nokogiri from 1.10.9 to 1.15.6
  • Upgrade msgpack from 1.3.3 to 1.7.2
  • Upgrade nio4r from 2.5.2 to 2.7.3

@nicolastemciuc
Copy link
Collaborator Author

nicolastemciuc commented Sep 4, 2024 •
edited
Loading

It seems that we need to update the node version in the ci.yml in order to continue using it

Screenshot 2024-09-04 at 4 27 26 PM

@nicolastemciuc
Copy link
Collaborator Author

nicolastemciuc commented Sep 5, 2024 •
edited
Loading

It seems to be related with this issue , so I remove the webdrivers gem and update the selenium-webdriver gem as he suggested.

@santiagorodriguez96
Copy link
Contributor

It seems to be related with this issue , so I remove the webdrivers gem and update the selenium-webdriver gem as he suggested.

We are not actually updating selenium-web-drivers though, right?

santiagorodriguez96
santiagorodriguez96 approved these changes Sep 5, 2024
View reviewed changes
Copy link
Contributor

@santiagorodriguez96 santiagorodriguez96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@nicolastemciuc
Copy link
Collaborator Author

My bad, it seems that's at the latest version possible

@nicolastemciuc nicolastemciuc merged commit 61d0a22 into master Sep 5, 2024
1 check passed
@santiagorodriguez96 santiagorodriguez96 deleted the nt--upgrade-gems-to-solve-conflicts branch September 5, 2024 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@santiagorodriguez96 santiagorodriguez96 santiagorodriguez96 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nicolastemciuc @santiagorodriguez96