Type level is_authorized guarding #71
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
john-h-kastner-aws
approved these changes
Nov 7, 2023
| pub struct GetList; | ||
| impl Action for GetList { | ||
| fn action() -> &'static EntityUid { | ||
| &ACTION_GET_LIST |
There was a problem hiding this comment.
Could these functions be the only source of truth for the action EntityUid?
andrewmwells-amazon
approved these changes
Nov 7, 2023
andrewmwells-amazon
approved these changes
Nov 7, 2023
| self.is_authorized(&r.uid, &*ACTION_EDIT_SHARE, &r.list)?; | ||
| let list = self.entities.get_list(&r.list)?; | ||
| let proof = self.is_authorized::<actions::EditShare>(&r.uid, &r.list)?; | ||
| let list = self.entities.get_list(&r.list, &proof)?; |
There was a problem hiding this comment.
nit: Is this different than the witness design pattern? https://willcrichton.net/rust-api-type-patterns/witnesses.html If not, I'd suggest using witness as the parameter name.
cdisselkoen
approved these changes
Nov 16, 2023
| self.is_authorized(&r.uid, &*ACTION_EDIT_SHARE, &r.list)?; | ||
| let list = self.entities.get_list(&r.list)?; | ||
| let proof = self.is_authorized::<actions::EditShare>(&r.uid, &r.list)?; | ||
| let list = self.entities.get_list(&r.list, &proof)?; |
Comment on lines
+396
to
+397
| principal: &A::Principal, | ||
| resource: &A::Resource, |
There was a problem hiding this comment.
very nice, restricting the prnicipal and resource args to is_authorized() on the type level as well
| pub struct SealedBundle(Entities); | ||
|
|
||
| impl SealedBundle { | ||
| pub fn unwrap(self, _proof: impl ReadAll) -> Entities { |
There was a problem hiding this comment.
what's the difference between impl ReadAll and AuthWitness<impl ReadAll> here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.