Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix PathItem::resolveReferences() for array fields #87

Closed
wants to merge 1 commit into from
Closed

Fix PathItem::resolveReferences() for array fields #87

wants to merge 1 commit into from

Commits on Dec 14, 2020

  1. Fix PathItem::resolveReferences() for array fields 

    The previous code `$this->$attribute[$k] = $referencedObject` had
no effect  if the value of `$attribute` is an array (as for instance
in the case of `parameters`), because `$this->$attribute` invokes
`SpecBaseObject::__get()`, which does *not* return a reference. Indeed
PHP issued `Notice: Indirect modification of overloaded property
cebe\openapi\spec\PathItem::$parameters has no effect` in this case.
    @rv1971
    rv1971 committed Dec 14, 2020
    Configuration menu
    Copy the full SHA
    56875dd View commit details
    Browse the repository at this point in the history