Unresolved reference while instantiating Encoding

[karsa-mistmere]

If there's a $ref within a multipart/form-data requestBody, the Encoding will be instantiated with a Reference object instead of a Schema object as expected resulting in a TypeErrorException.

To reproduce, just parse the following OpenAPI schema:

openapi: "3.0.0"
info:
  version: 1.0.0
  title: Multipart demo
paths:
  /pets:
    post:
      summary: Create a pet
      operationId: createPets
      tags:
        - pets
      requestBody:
        content:
          multipart/form-data:
            schema:
              type: object
              properties:
                pet:
                  $ref: '#/components/schemas/Pet'
                petImage:
                  type: string
                  format: binary
            encoding:
              pet:
                contentType: application/json
              petImage:
                contentType: image/*
          application/json:
            schema:
              $ref: '#/components/schemas/Pet'
        description: The pet to be created
        required: true
      responses:
        '201':
          description: Null response

components:
  schemas:
    Pet:
      type: object
      properties:
        id:
          type: integer
          format: int64
        name:
          type: string

Since this parameter is only ever used to guess the default encoding type of a property if and when it is not explicitly defined, I propose to skip the schema parameter altogether if during instantiation it is still an unresolved reference (otherwise we would have to pre-resolve references during instantiation leading to all other kinds of mishaps and a very substantial rewrite of the whole project).

php-openapi/src/spec/MediaType.php

Lines 56 to 62 in aafedb5

	// Don't pass the schema if it's still an unresolved reference.
	if (this->schema->properties[$property] instanceof Reference) {
	$encoding[$property] = new Encoding($encodingData);
	}
	else {
	$encoding[$property] = new Encoding($encodingData, $this->schema->properties[$property] ?? null);
	}

[cebe]

Thanks for the fix! Could you add a test case to verify it?

[karsa-mistmere]

Sure, I've commited it.

[cebe]

Thank you!