Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use file normalise and load library using absolute path #345

Merged
merged 1 commit into from
May 15, 2020

Conversation

kiwiroy
Copy link
Contributor

@kiwiroy kiwiroy commented May 14, 2020

These changes result in no failed tests on macOS 10.15 as seen in #344, and might be useful for #304.

@codecov
Copy link

codecov bot commented May 15, 2020

Codecov Report

Merging #345 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #345   +/-   ##
=======================================
  Coverage   99.43%   99.43%           
=======================================
  Files           2        2           
  Lines        3015     3015           
=======================================
  Hits         2998     2998           
  Misses         17       17           
Impacted Files Coverage Δ
modulecmd.tcl.in 99.41% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c0a3367...1f0dd90. Read the comment docs.

@xdelaruelle xdelaruelle merged commit df1cdab into cea-hpc:master May 15, 2020
@xdelaruelle
Copy link
Member

Thanks a lot for the bug report and the fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants