This repository has been archived by the owner on May 7, 2021. It is now read-only.
Fix focus #1325
Merged
Fix focus #1325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sastels
commented
Feb 7, 2020
| @@ -13,19 +13,20 @@ i18n.load('en', { en }) | |||
| i18n.activate('en') | |||
|
|
|||
| describe('<BusinessPage />', () => { | |||
| afterEach(cleanup) | |||
| beforeEach(() => (global.scrollTo = jest.fn())) | |||
There was a problem hiding this comment.
The window object that the app uses only exists when running in a browser, not when running in jest. So for the tests to use window.scrollTo(), we make the function manually by setting it to a fake jest function. And for some reason we set global.scrollTo rather than window.scrollTo 🤷♂
sastels
requested review from
kevinyang06,
DianeLiu2019,
amazingphilippe,
khalidelaggan,
naomiseminega and
ngosset
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1142
Description
When a new screen loads, scroll to the top. Previously the focus was at the middle of the new screen.
There's more lines of code here fixing the tests than fixing the app 🤦♂
Checklist: