Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update setting page styling for API #4754

Merged
merged 4 commits into from
Dec 2, 2024
Merged

Conversation

timarney
Copy link
Member

@timarney timarney commented Dec 2, 2024

Summary | Résumé

Screenshot 2024-12-02 at 9 37 02 AM
  • Have the download radio selected after deletion to make it clear that this is now the default

Fixes #4724

revert-to-download.mp4
  • Make the info banner at the top of the page match the style of the delete API key one.
Screenshot 2024-12-02 at 9 50 26 AM
  • Add a mb-20 between each section to visually separate them a bit more.

👉 Note -- 20 was too much using 10
Screenshot 2024-12-02 at 9 53 50 AM

  • The sub text on the API radio is a different size - It should probably have the same classes as the highlighted span

Fixes #4737

Screenshot 2024-12-02 at 9 55 47 AM
  • Place the API key ID tool tip after "API key ID" rather than the number itself.
Screenshot 2024-12-02 at 9 57 45 AM

Copy link
Contributor

github-actions bot commented Dec 2, 2024

Copy link
Member

@anikbrazeau anikbrazeau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM on Design QA! :D Thanks Tim!

Copy link
Contributor

@thiessenp-cds thiessenp-cds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@timarney timarney enabled auto-merge (squash) December 2, 2024 17:15
@timarney timarney merged commit a83bff9 into main Dec 2, 2024
13 checks passed
@timarney timarney deleted the setting-page-styling branch December 2, 2024 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants