Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add tests around rehydrateFormResponses #4720

Merged
merged 11 commits into from
Nov 28, 2024

Conversation

dsamojlenko
Copy link
Member

@dsamojlenko dsamojlenko commented Nov 27, 2024

Summary | Résumé

Wrapping some tests around rehydrateFormResponses in anticipation of some refactoring.

Copy link
Contributor

@timarney timarney changed the title Add tests around rehydrateFormResponses chore: Add tests around rehydrateFormResponses Nov 28, 2024
@timarney
Copy link
Member

Might be worth using this style of fixture for each type of input https://github.com/cds-snc/platform-forms-client/pull/4730/files#diff-82e9d6811ceb54ab73c76d8a8301fb4c25df0b946b148ff25148fc45f184e5b3R6

Would be easier to maintain and update as we bring on more components.

@dsamojlenko dsamojlenko marked this pull request as ready for review November 28, 2024 19:34
@dsamojlenko dsamojlenko merged commit a61f74b into main Nov 28, 2024
13 checks passed
@dsamojlenko dsamojlenko deleted the chore/add_tests_rehydrateFormResponses branch November 28, 2024 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants