Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add New Relic + devcontainer goodies #201

Merged
merged 5 commits into from
Nov 27, 2024
Merged

Add New Relic + devcontainer goodies #201

merged 5 commits into from
Nov 27, 2024

Conversation

jimleroyer
Copy link
Member

@jimleroyer jimleroyer commented Nov 21, 2024

Summary | Résumé

  • Adds New Relic to the dd-api project.
  • Adds CLI tools such as fzf and ripgrep.
  • Bring latest vscode extensions used in other gcnotify devcontainers.
  • Standardize on docker-compose instead of relying solely on devcontainer.json (more features and flexibility).
  • Configure the dd-api devcontainer to be on the same docker network as others (api and admin), providing the ability to easily communicate with these (ping notify-api, ping notify-admin, ping db, ping redis all works).

Related Issues | Cartes liées

Test instructions | Instructions pour tester la modification

No instructions for these changes specifically. To see New Relic data around dd-api, we will certainly need to add some more env variables for dd-api in kubernetes manifests.

Release Instructions | Instructions pour le déploiement

None.

Reviewer checklist | Liste de vérification du réviseur

  • This PR does not break existing functionality.
  • This PR does not violate GCNotify's privacy policies.
  • This PR does not raise new security concerns. Refer to our GC Notify Risk Register document on our Google drive.
  • This PR does not significantly alter performance.
  • Additional required documentation resulting of these changes is covered (such as the README, setup instructions, a related ADR or the technical documentation).

⚠ If boxes cannot be checked off before merging the PR, they should be moved to the "Release Instructions" section with appropriate steps required to verify before release. For example, changes to celery code may require tests on staging to verify that performance has not been affected.

gunicorn_config.py Dismissed Show dismissed Hide dismissed
gunicorn_config.py Dismissed Show dismissed Hide dismissed
@jimleroyer jimleroyer changed the title Add New Relic Add New Relic + devcontainer goodies Nov 21, 2024

networks:
notify-network:
external: true
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

$ ping notify-api
PING notify-api (172.21.0.4) 56(84) bytes of data.
64 bytes from gc-notify-notify-api-1.notify-network (172.21.0.4): icmp_seq=1 ttl=64 time=0.091 ms

$ ping notify-admin
PING notify-admin (172.21.0.5) 56(84) bytes of data.
64 bytes from notification-admin_devcontainer-notify-admin-1.notify-network (172.21.0.5): icmp_seq=1 ttl=64 time=0.085 ms

$ ping db
PING db (172.21.0.3) 56(84) bytes of data.
64 bytes from gc-notify-db-1.notify-network (172.21.0.3): icmp_seq=1 ttl=64 time=0.080 ms

$ ping redis
PING redis (172.21.0.2) 56(84) bytes of data.
64 bytes from gc-notify-redis-1.notify-network (172.21.0.2): icmp_seq=1 ttl=64 time=0.086 ms

Copy link
Contributor

@whabanks whabanks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Tested out the connectivity between the API and doc-API container and all is well.

@jimleroyer jimleroyer merged commit 8c66ce2 into main Nov 27, 2024
3 checks passed
@jimleroyer jimleroyer deleted the feat/new-relic branch November 27, 2024 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants