-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add New Relic + devcontainer goodies #201
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
jimleroyer
commented
Nov 21, 2024
|
||
networks: | ||
notify-network: | ||
external: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
$ ping notify-api
PING notify-api (172.21.0.4) 56(84) bytes of data.
64 bytes from gc-notify-notify-api-1.notify-network (172.21.0.4): icmp_seq=1 ttl=64 time=0.091 ms
$ ping notify-admin
PING notify-admin (172.21.0.5) 56(84) bytes of data.
64 bytes from notification-admin_devcontainer-notify-admin-1.notify-network (172.21.0.5): icmp_seq=1 ttl=64 time=0.085 ms
$ ping db
PING db (172.21.0.3) 56(84) bytes of data.
64 bytes from gc-notify-db-1.notify-network (172.21.0.3): icmp_seq=1 ttl=64 time=0.080 ms
$ ping redis
PING redis (172.21.0.2) 56(84) bytes of data.
64 bytes from gc-notify-redis-1.notify-network (172.21.0.2): icmp_seq=1 ttl=64 time=0.086 ms
whabanks
approved these changes
Nov 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Tested out the connectivity between the API and doc-API container and all is well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary | Résumé
ping notify-api
,ping notify-admin
,ping db
,ping redis
all works).Related Issues | Cartes liées
Test instructions | Instructions pour tester la modification
No instructions for these changes specifically. To see New Relic data around dd-api, we will certainly need to add some more env variables for dd-api in kubernetes manifests.
Release Instructions | Instructions pour le déploiement
None.
Reviewer checklist | Liste de vérification du réviseur