Don't add versions ignored by git #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
klausenbusk
commented
Jul 3, 2020
|
Tested with |
tc80
previously approved these changes
Jul 5, 2020
tc80
reviewed
Jul 5, 2020
autoupdate would panic as `git add` exit with a non-zero exit status if the path is ignored. Fix #58
|
@tc80 both issue should be fixed now. |
tc80
approved these changes
Jul 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
autoupdate would panic as
git addexit with a non-zero exit status ifthe path is ignored.
Fix #58
This hasn't been tested, but the dirty fix was tested (https://github.com/klausenbusk/tools/compare/4268b20...5054f34), this is mostly a refactor of the dirty fix.Edit see: #67 (comment)