Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update carbon-charts w/ npm auto-update #1826

Merged
merged 2 commits into from
Jul 17, 2024
Merged

Update carbon-charts w/ npm auto-update #1826

merged 2 commits into from
Jul 17, 2024

Conversation

nstuyvesant
Copy link
Contributor

@nstuyvesant nstuyvesant commented Jun 18, 2024 •
edited
Loading

Change

  • Carbon Charts started adding .cjs extension in place of .js for UMD files as the package.json's type was set to module causing Webpack to misidentify the UMD bundles as ESM.
  • New naming follows the default that Vite.js uses.

@MattIPv4 MattIPv4 changed the title fix(carbon-charts): now uses .cjs extension instead of .js Update carbon-charts w/ npm auto-update Jul 17, 2024
MattIPv4
MattIPv4 approved these changes Jul 17, 2024
View reviewed changes
Copy link
Member

@MattIPv4 MattIPv4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, ty

@MattIPv4 MattIPv4 merged commit dbfee52 into cdnjs:master Jul 17, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MattIPv4 MattIPv4 MattIPv4 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nstuyvesant @MattIPv4