-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Should download the VM as well #2
Comments
Not a really realistic assumption, but I'm not keen on downloading VMs all over the place. We'll see. See #2
I'm not fond of getting a VM for each project directory… I modified Fari to try running @hernanmd What do you think? |
Can make an option in the script to download the VM. So, we get fari getvm vm70 and it would just do that. |
I would love an option to download the VM if not present in the current directory. The thing is I suspect most people will not have the pharo-ui in the $PATH for diverse reasons : multiple pharo versions installed (is the pharo-ui script versioned?), workflows with 1 image per directory, avoiding to configure $PATH, etc. Maybe something like: IMAGENAME="Pharo.image"
# Returns 0 if command was found in the current system, 1 otherwise
command_exists () {
type "$1" &> /dev/null ;
return $?
}
check_downloader () {
echo_line "Checking for wget or curl..."
if command_exists wget ; then
echo_nline "wget found..."
DOWNLOAD_APP=wget
DOWNLOAD_LIST_PARAMS="--no-check-certificate -O ${LIST_FILE}"
DOWNLOAD_PHARO_PARAMS="-O-"
elif command_exists curl ; then
echo_nline "curl found..."
DOWNLOAD_APP=curl
DOWNLOAD_LIST_PARAMS="-o "$LIST_FILE
DOWNLOAD_PHARO_PARAMS=""
else
echo_nline "I require wget or curl, but it's not installed. (brew install wget?) Aborting."
exit 1
fi
}
check_download_app () {
echo -n "Checking Pharo installation already present..."
if [ ! -f $IMAGENAME ]; then
echo "not found"
echo "Downloading Pharo..."
exec $DOWNLOAD_APP $DOWNLOAD_PHARO_PARAMS get.pharo.org/$PHARO_VERSION+vm | bash
else
echo "found $IMAGENAME in the current directory"
fi
if [ ! -f pharo ]; then
echo "Pharo not downloaded correctly, exiting"
exit 1
fi
} |
No description provided.
The text was updated successfully, but these errors were encountered: