fix(transliterator): extraneous closing brace in link formatter #630
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Link formatter includes an extraneous closing brace `}` at the end of it, which makes the links invalid (as it typically ends with `?lang=python%2F`).
eladb
reviewed
Dec 1, 2021
| @@ -246,7 +246,7 @@ function linkFormatter(type: docgen.TranspiledType): string { | |||
| // linking to them. | |||
| const hash = sanitize(type.fqn); | |||
| const query = `?lang=${type.language.toString()}${type.submodule ? `&submodule=${type.submodule}` : ''}`; | |||
| return `/packages/${packageName}/v/${packageVersion}/api/${hash}${query}}`; | |||
| return `/packages/${packageName}/v/${packageVersion}/api/${hash}${query}`; | |||
eladb
approved these changes
Dec 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link formatter includes an extraneous closing brace
}at the end ofit, which makes the links invalid (as it typically ends with
?lang=python%2F).By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license