-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: allow multi region stackset deployments with file assets #325
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- update projenrc
- update example - prefix should not have a region at the end
Worth calling out that you are only talking about file assets when you say "assets". i.e. Docker image assets are not supported |
good point. unfortunately docker assets would need a stable upstream construct similar to https://github.com/cdklabs/cdk-ecr-deployment. it is out of scope of this construct to build this at this time. similar to how the Service Catalog L2 does not support docker assets at this time. |
Of note this merge breaks the previous bucket asset setup. If you have an asset bucket that does not have a region name in the bucket name, you need to deprecate that bucket, and add a new bucket that contains the region in the name. For anyone else, note IMO, a sanity check against the array of |
Actually, all dependencies are updated, but cdklabs/cdk-stacksets#325 has been merged and released with 0.0.150 and this tests if it solved the issue here. Sadly it did not.
Fixes #159
Added support to use file assets across multiple regions in one stackset. This still requires to pass the asset bucket(s) to the construct. It also uses a bucket "prefix" which the stackset construct will append "-${region}" to the end of the bucket name. For example, all asset buckets across each region will need to have the same prefix like "assetbucket" and will need the region appended at the end "assetbucket-us-east-1" "assetbucket-us-west-2". it is out of scope of the construct to create these buckets at this time.