feat: Add environment section in job definition to enable user to add manual approval gate for deploy jobs #160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…l approval gate for deploy jobs
|
Hi @liweiyi88, thanks for submitting this PR! What you've added is interesting but I'd like to dive in to what feature you're trying to unlock first. In the code it looks like you just want to add an environment variable, and I'm curious how that might lead to a manual approval gate. This might be best discussed via a github issue. Do you mind submitting an issue that to propose the change you want to make as well as the use case it unlocks? Thanks. |
|
@kaizen3031593 sure thing, I have added the description in #162 . Please let me know if you have any further questions Thanks. |
|
closed as we provided an extra api to enable this #178 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds environment section in deploy jobs so it will give people a chance to set up a manual approval gate if they like.