fix(sam-spec): replace AlexaSkillEvent.Variables with AlexaSkillEvent.SkillId
#459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rix0rrr
approved these changes
Aug 14, 2023
|
You need to edit |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to a conflict with the base branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The spec we use claims that AlexaSkillEvent has a Variables property, but it does not: https://docs.aws.amazon.com/serverless-application-model/latest/developerguide/sam-property-function-alexaskill.htmlThis change: https://github.com/awslabs/goformation/pull/613/files made the spec match the SAM docs. The property is marked as optional, but it is the only possible property; make it required. Our codegen will now only match the strongest possible type in type unions (which the inputs to function events are) and
AlexaSkillEventwill never be chosen, because it currently has no required properties. This results in theAlexaSkillEventbeing ignored during synthesis, which creates templates with missing properties.Making
SkillIdrequired makes theAlexaSkillEventusable in CDK apps.